Still process MIDI Modulator when output is not connected (#375)

Chowdhury-DSP · Mar 2, 2025 · 3e61f31 · 3e61f31
1 parent 6ef1720
commit 3e61f31
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/processors/BaseProcessor.cpp b/src/processors/BaseProcessor.cpp
@@ -383,7 +383,20 @@ juce::Point<int> BaseProcessor::getPosition (juce::Rectangle<int> parentBounds)
     return (editorPosition * juce::Point { (float) parentBounds.getWidth(), (float) parentBounds.getHeight() }).toInt();
 }
 
-bool BaseProcessor::isOutputModulationPortConnected()
+bool BaseProcessor::onlyHasModulationOutput() const
+{
+    if (getProcessorType() != Modulation)
+        return false;
+
+    for (int portIdx = 0; portIdx < getNumOutputs(); ++portIdx)
+    {
+        if (getOutputPortType (portIdx) != PortType::modulation)
+            return false;
+    }
+    return true;
+}
+
+bool BaseProcessor::isOutputModulationPortConnected() const
 {
     if (getProcessorType() != Modulation)
         return false;

diff --git a/src/processors/BaseProcessor.h b/src/processors/BaseProcessor.h
@@ -189,7 +189,8 @@ class BaseProcessor : private JuceProcWrapper
     int getForwardingParameterSlotIndex() const noexcept { return forwardingParamsSlotIndex; }
     void setForwardingParameterSlotIndex (int index) { forwardingParamsSlotIndex = index; }
 
-    bool isOutputModulationPortConnected();
+    bool onlyHasModulationOutput() const;
+    bool isOutputModulationPortConnected() const;
     const std::vector<String>* getParametersToDisableWhenInputIsConnected (int portIndex) const noexcept;
     const std::vector<String>* getParametersToEnableWhenInputIsConnected (int portIndex) const noexcept;
 

diff --git a/src/processors/chain/ProcessorChain.cpp b/src/processors/chain/ProcessorChain.cpp
@@ -214,7 +214,8 @@ void ProcessorChain::processAudio (AudioBuffer<float>& buffer, const MidiBuffer&
         // process standalone modulation ports
         auto noInputsConnected = processor->getNumInputConnections() == 0;
         auto modOutputConnected = processor->isOutputModulationPortConnected();
-        if (noInputsConnected && modOutputConnected)
+        auto onlyModOut = processor->onlyHasModulationOutput();
+        if (noInputsConnected && (modOutputConnected || onlyModOut))
             runProcessor (processor, inputBuffer, outProcessed);
     }