Fix FIRST_BLOCK_VOTED post-upgrade check #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/pkg/daemon/checks/post.go
Outdated
| // when the chain halts at height N, the height returned in consensus state should be N+1 | ||
| // because the _next_ block is being voted on | ||
| // so we should return BlockSkipped only if the state goes further than that | ||
| if currentHeight > height+1 { |
There was a problem hiding this comment.
i think we should not change this function, rather, call CheckBlockSignedBy(.., UPGRADE_HEIGHT+1, ..)
tschuyebuhl
force-pushed
the
first-block-voted-check
branch
from
15ae333 to
dccf9eb
Compare
DavidVentura
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is in the comment. I am not 100% sure about the assumption, will attempt to verify it with upcoming upgrades before merging.