fsnotify file watcher #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaczanowski
commented
Feb 23, 2025
| @@ -0,0 +1,101 @@ | |||
| package file_watcher | |||
There was a problem hiding this comment.
This is old file_watcher.go unmodified (except renaming to PollingFileWatcher)
tschuyebuhl
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
We noticed that sometimes the file watcher does not pick up the upgrade, while it is hard to point finger at the rootcause I've came up with the attempt to use the fsnotify to detect the file changes.
It may or may not be a better option, we'll see.
NOTE: This change is "in addition" to the previous (polling watcher) that is kept for backwards compatibility just in case the new one is as faulty as old one. Or my troubleshooting was wrong, and the issue is elsewhere.
To use the fsnotify watcher set the interval to 0 (see config)