Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export pre/post check status label in blazar_blocks_to_upgrade_height #35

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Export pre/post check status label in blazar_blocks_to_upgrade_height #35

merged 3 commits into from
Feb 14, 2025

Conversation

sin3point14
Copy link
Contributor

Now we have a label for each pre/post check and the value gives the check status.
examples:

blazar_blocks_to_upgrade_height{CHAIN_HEIGHT_INCREASED="PENDING",FIRST_BLOCK_VOTED="PENDING",GRPC_RESPONSIVE="PENDING",PULL_DOCKER_IMAGE="FINISHED",SET_HALT_HEIGHT="FINISHED",chain_id="dimension_37-1",compose_file="...",hostname="...",upgrade_height="12943744",upgrade_name="test-metrics",upgrade_status="ACTIVE",upgrade_step="PRE_UPGRADE_CHECK",validator_address="CA7978B0C8D1968449053DA54166A8DA6A8DC67E",version="devel"} 8

blazar_blocks_to_upgrade_height{CHAIN_HEIGHT_INCREASED="PENDING",FIRST_BLOCK_VOTED="PENDING",GRPC_RESPONSIVE="RUNNING",PULL_DOCKER_IMAGE="FINISHED",SET_HALT_HEIGHT="FINISHED",chain_id="dimension_37-1",compose_file="...",hostname="...",upgrade_height="12943744",upgrade_name="test-metrics",upgrade_status="EXECUTING",upgrade_step="POST_UPGRADE_CHECK",validator_address="CA7978B0C8D1968449053DA54166A8DA6A8DC67E",version="devel"} 0

DavidVentura
DavidVentura approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@DavidVentura DavidVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, can you fix the linter issues before merging?

@sin3point14 sin3point14 merged commit f10ca89 into main Feb 14, 2025
2 checks passed
@sin3point14 sin3point14 deleted the substep-metric branch February 14, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidVentura DavidVentura DavidVentura approved these changes

@mkaczanowski mkaczanowski Awaiting requested review from mkaczanowski

@qezz qezz Awaiting requested review from qezz

@tschuyebuhl tschuyebuhl Awaiting requested review from tschuyebuhl

@vchong vchong Awaiting requested review from vchong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sin3point14 @DavidVentura