Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Borderless Mining game options menu crash #1021

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

XXMA16
Copy link

@XXMA16 XXMA16 commented Mar 29, 2023

Both Optifine and Borderless Mining rely on TooltipFactory instead of TooltipFactoryGetter in 1.19.3 and up since the latter class got removed in this version. Fixing this is simple (just use the new class instead of the old one), although it requires those pesky New Mixins, MixinPlugins and Mixin Configurations. This time I made sure to test the patch before creating the PR so bad code doesn't get merged like last time due to me just hoping it doesn't break stuff in older versions:

  • 1.16.5 (BM 1.0.6 & FAPI 0.42.0)
  • 1.18.2 (FAPI 0.75.1)
  • 1.19 (BM 1.1.5 & FAPI 0.58.0)
  • 1.19.3 (BM 1.1.6 & FAPI 0.76.0)
  • 1.19.4 (BM 1.1.7 & FAPI 0.76.0)

fixed #1015

@Chocohead Chocohead merged commit 7f99ee6 into Chocohead:llama Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants