Video list filters labelling, button and sort select UI improvements #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
force-pushed
the
feat/filter-labels
branch
from
0cbd9c4 to
3f05a65
Compare
and rounded/uniformized border for filter/select
rigelk
force-pushed
the
feat/filter-labels
branch
from
3f05a65 to
f644701
Compare
Chocobozzz
requested changes
Jan 12, 2024
| <input formControlName="scope" type="radio" name="scope" id="scopeLocal" value="local" /> | ||
| <label for="scopeLocal" i18n>Local videos (this instance)</label> | ||
| </div> | ||
|
|
||
| <div class="peertube-radio-container"> | ||
| <div class="peertube-radio-container" [hidden]="true"> |
There was a problem hiding this comment.
Why is it hidden and note removed?
| @@ -42,16 +42,22 @@ | |||
| formControlName="sort" | |||
| [clearable]="false" | |||
| [searchable]="false" | |||
| [bindValue]="null" | |||
| [items]="getSortOptions()" | |||
There was a problem hiding this comment.
[items] must be immutable or the component will rebuild options indefinitely
| @@ -109,7 +114,9 @@ | |||
|
|
|||
| ::ng-deep { | |||
| .ng-select-container { | |||
There was a problem hiding this comment.
Can we have the same padding as other pastilles?
| } | ||
|
|
||
| .filters-toggle { | ||
| border: 2px solid pvar(--mainForegroundColor); | ||
| border: 1px solid; | ||
| border-color: #adadad #C6C6C6 lightgray; |
There was a problem hiding this comment.
Can we use peertube css variables to not break themes?
|
Closing due to inactivity. Does not hesitate to ask for the reopening :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays labels for languages and categories instead of the raw ids.
Changes radio buttons to checkboxes for scope selection.
Clearer sort selection with description and grouping by type of sort.
Rely on
peertube-checkboxwhenever possible for uniformity of style and conciseness.This PR might be improved by applying the same treatement as scope radio buttons to the type of video (live/vod) radio buttons.
Screenshots