Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ChiselItem in off hand to process left click of BitItem #1252

Open
wants to merge 3 commits into
base: version/latest
Choose a base branch
from

Conversation

koenigstag
Copy link

Related to issue #1249

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@koenigstag
Copy link
Author

koenigstag commented Sep 14, 2024

@marchermans
Copy link
Collaborator

Hello, thanks for your contribution.

The current behaviour is completely intended and works as it has for many years.
However I am okey with making this a toggleable behaviour. Could you add a configuration entry (that by default configures the old behaviour where you do not need the chisel) to the server side configuration, and then validate whether this behaviour is requested?

Greets,

Marc

marchermans added a commit that referenced this pull request Jan 4, 2025
Implement an optional balancing option to require a chisel in the offhand when breaking bits with a bit.
Fix an incompatibility with Lithium

Closes: #1252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants