Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ISyntaxNodeProvider to Skimmed type system member definitions #7938

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 21, 2025

Summary of the changes (Less than 80 chars)

  • Added ISyntaxNodeProvider to Skimmed type system member definitions.

Notes:

  • I decided to add this to most (if not all) type system members, instead of creating an issue for the rest.
  • I added RewriteMissingType to SchemaDebugFormatter, because MissingTypeDefinition implements INamedTypeDefinition which implements ISyntaxNodeProvider, so it also needed an implementation of ToSyntaxNode.
  • I updated RewriteDirectiveLocation to format the location, otherwise it's printed in PascalCase.

@glen-84 glen-84 marked this pull request as draft January 21, 2025 15:06
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (b40f1f4) to head (02d5794).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7938      +/-   ##
==========================================
+ Coverage   74.33%   74.36%   +0.02%     
==========================================
  Files        2880     2880              
  Lines      150303   150336      +33     
  Branches    17480    17482       +2     
==========================================
+ Hits       111722   111790      +68     
+ Misses      32765    32726      -39     
- Partials     5816     5820       +4     
Flag Coverage Δ
unittests 74.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review January 21, 2025 15:21
@michaelstaib michaelstaib merged commit 7c951da into main Jan 21, 2025
5 checks passed
@michaelstaib michaelstaib deleted the gai/syntax-node-provider branch January 21, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants