The OperationExecutor does not emit error results #7632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@david-driscoll thanks for contributing this ... I will package it into 14.1 |
|
OK ... I will need to look into why the tests fail. |
|
I missed those tests myself, I'll try and take a look as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
OperationExecutordoes not emit any error results, because theResultis always null.I was not sure how best to fix this, and I'm not as deeply involved in the spec, so this is my best guess atm.
Basically if any error results are found,
OperationExecutorwillOnNextand complete the observable. This could be wrong behavior instead of justOnNextthe result and move on.I made the change to both
OperationExecutorandStorelessOperationExecutorso their behavior would be consistent. (And to help identify if I'm thinking about errors all the wrong way).