-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Greek font update (M2-8442) #576
base: dev
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up all the stray font definitions (there was basically no thought put into consolidating styling when this app was built 😞). Great work!
Meant to approve this earlier but dev was down at the time and I wanted to do some minimal testing. Nice work @andrevitalb |
📝 Description
🔗 Jira Ticket M2-8442
This PR adds Lato as a font for greek characters with the use of CSS's
unicode-range
property. Atkinson remains as the default font for non-greek characters.Some minor cleanup work was done as well for manual overrides along the project by defaulting MUI and the project to the following:
font-family: "Lato", "Atkinson", sans-serif
(configuration for the expected behavior added).📸 Screenshots
🪤 Peer Testing
This is only visually testable. Lato should be the default font for greek characters, Atkinson should be present elsewhere.
✏️ Notes
In order to achieve maximum cohesion between the two fonts used, Lato Black was used, instead of the default Lato Bold, since its weight more closely aligns with Atkinson's Bold.