Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint update (M2-7725) #565

Merged
merged 4 commits into from
Jan 15, 2025
Merged

chore: eslint update (M2-7725) #565

merged 4 commits into from
Jan 15, 2025

Conversation

ChaconC
Copy link
Contributor

@ChaconC ChaconC commented Jan 13, 2025

Merged dev into #531, opening PR to test amplify environment

Original Description:

📝 Description

🔗 Jira Ticket M2-7725

Changes include:

  • Upgrade deps (Eslint, prettier, etc.)
  • Migrate eslint config from the old version to a new one (eslint flat style)
  • Resolve all eslint errors and warnings
  • Upgrade axios
  • Some packages that have ability to upgrade the minor version

Test process:

  • yarn test
  • yarn build
  • Run the project and execute the minimal flow (Login, Open applet, Open Activity, Pass the Activity, Submit Answers)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-565.d15zn9do8xbzga.amplifyapp.com

@ChaconC ChaconC marked this pull request as ready for review January 15, 2025 14:48
@ChaconC ChaconC mentioned this pull request Jan 15, 2025
Copy link

@felipeMetaLab felipeMetaLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ChaconC ChaconC merged commit cff1285 into dev Jan 15, 2025
3 checks passed
@ChaconC ChaconC deleted the chore/M2-7725_eslint_update branch January 15, 2025 17:16
@farmerpaul
Copy link
Contributor

@ChaconC just a heads-up that the version of node we have defined in .nvmrc (v20.5.1) is apparently no longer compatible with this new version of ESLint:

CleanShot 2025-01-28 at 17 58 30@2x

I assume our CI ignores .nvmrc, so this didn't get caught automatically, and maybe other engineers' environments aren't configured to auto-select the node version based on .nvmrc. Curious what you use for node version management?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants