Fix/243 add route to allow user to change username #623
Conversation
…me, add a parameter in api to change username value
There was a problem hiding this comment.
The code changes to girderformindlogger/web_client are unnecessary (see #635), and we definitely don't need the built files in the repo; they should be built after downloading.
|
|
||
| login = cherrypy.request.body.params['login'] | ||
| user['firstName'] = firstName if firstName is not None else "" | ||
| user['login'] = login if login is not None else user['login'] |
There was a problem hiding this comment.
We're phasing out userId visibility, so rather than adding this functionality to an already deprecated function that requires userId, we should make or update a call that relies on a user being logged in and modifies only that user. See #635.
| @@ -812,19 +812,21 @@ def getUsersDetails(self): | |||
| .errorResponse(('You do not have write access for this user.', | |||
| 'Must be an admin to create an admin.'), 403) | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
This (already deprecated) API call doesn't include the newly added login in the parameters for the interactive documentation.
| displayName="", | ||
| email="", | ||
| admin=False, | ||
| status=None, | ||
| firstName=None, | ||
| lastName=None |
There was a problem hiding this comment.
I'm not sure if any frontends are still using the lastName parameter of this deprecated call.
| @@ -9,7 +9,8 @@ replica_set = None | |||
|
|
|||
| [server] | |||
| # Set to "production" or "development" | |||
| mode = "production" | |||
| mode = "development" | |||
| # mode = "production" | |||
There was a problem hiding this comment.
I don't think we want to commit this change to master
| displayName | ||
| ) else firstName if firstName is not None else "" | ||
|
|
||
| login = cherrypy.request.body.params['login'] |
There was a problem hiding this comment.
If we're adding a param to a call, we should in its decorator rather than picking it out of the request like this.
No description provided.