Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix clearing of one-time-completion manual self-report assessments from notification (M2-8144, M2-8160) #889

Conversation

farmerpaul
Copy link
Contributor

@farmerpaul farmerpaul commented Nov 1, 2024

📝 Description

🔗 Jira Ticket M2-8144
🔗 Jira Ticket M2-8160

When tapping a notification to start a manual self-report assessment, the targetSubjectId was not being normalized to null as is needed to identify self-reports elsewhere in the app. Fixed this at the NotificationBuilder step.

🪤 Peer Testing

Preconditions:

  • User has an applet with activity that is set to Auto-assign: false and has a manual self-report assignment
  • Add new scheduled event for activity:
    • Repeats daily
    • Notification = in the next 5 minutes (or however long it takes you to refresh and force-close the applet)

Steps to reproduce:

Online mode:

  1. Refresh the applets list to ensure it has the latest updates from the activity (including the notification setting)
  2. Kill (close) the app
  3. Wait for the notification time
  4. Start the Activity by tapping the notification
  5. Complete activity
    Expected outcome: Activity is hidden from the list of activities.

Offline mode:

  1. Refresh the applets list to ensure it has the latest updates from the activity (including the notification setting)
  2. Kill (close) the app
  3. Take internet offline
  4. Wait for the notification time
  5. Start the Activity by tapping the notification
  6. Complete activity
    Expected outcome: Activity is hidden from the list of activities.

When tapping a notification to start a manual self-report assessment,
the `targetSubjectId` was not being normalized to `null` as is done
elsewhere in the app. Fixed this at the `NotificationBuilder` step.
@farmerpaul farmerpaul changed the title fix: Fix clearing of one-time-completion manual self-report assessments from notification (M2-8144) fix: Fix clearing of one-time-completion manual self-report assessments from notification (M2-8144, M2-8160) Nov 1, 2024
@sultanofcardio
Copy link
Contributor

Tested both scenarios and it works as expected ✅

@farmerpaul farmerpaul merged commit 8e6a21f into release/2.5.0 Nov 1, 2024
4 checks passed
@farmerpaul farmerpaul deleted the fix/M2-8144-notification-tap-one-time-completion-manual-self-report branch November 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants