Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/m2 8061 changing terms of service #877

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

felipeMetaLab
Copy link
Contributor

@felipeMetaLab felipeMetaLab commented Oct 25, 2024

📝 Description

🔗 Jira Ticket M2-8061

This PR includes the following updates:

  • Added Privacy Policy links to the Sign In, Sign Up, and About pages.
  • Added Terms of Service link to the About page.
  • Improved handling of line breaks for the Greek language.
  • Created a helper function to streamline link sharing across components.
  • Additionally, some minor fixes were made to enhance overall functionality.

📸 Screenshots

signIn:
<img width="332" alt="Screenshot 2024-10-25 at 10 52 25 AM" src="https://github.com/user-att
Screenshot 2024-10-25 at 11 48 06 AM
achments/assets/053aff8f-b4fb-4578-b658-104a34ebc3bf">
Screenshot 2024-10-25 at 11 48 13 AM

signUp:
Screenshot 2024-10-25 at 11 46 44 AM
Screenshot 2024-10-25 at 11 46 56 AM
Screenshot 2024-10-25 at 11 47 08 AM

ENGLISH:
Screenshot 2024-10-23 at 2 55 15 PM

GREEK BEFORE:
Screenshot 2024-10-23 at 2 39 40 PM

GREEK AFTER:
Screenshot 2024-10-23 at 2 55 51 PM
Screenshot 2024-10-23 at 2 56 03 PM

FRENCH:
Screenshot 2024-10-23 at 3 03 02 PM

🪤 Peer Testing

  • lauch the app

to test in english:

  • navigate to signIn, signUp and check the new privacy policy link ( I left some prints showing where its located )
  • after the sigIn go to about screen clicking the button at the bottom of the first screen, scroll down and check the new pricavy policy and terms of service link.

to test in other languages:

  • go to user settings and change the language
  • now perform the same test mentioned before in about page, signIn and SignUp

✏️ Notes

Any question let me know, thanks.

@felipeMetaLab felipeMetaLab merged commit 3bb27ad into dev Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants