Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/aadding privacy policy to app, creating a helper to call OpeU… #874

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

felipeMetaLab
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-8061

This PR includes the following updates:

  • Added Privacy Policy links to the Sign In, Sign Up, and About pages.
  • Added Terms of Service link to the About page.
  • Improved handling of line breaks for the Greek language.
  • Created a helper function to streamline link sharing across components.
  • Additionally, some minor fixes were made to enhance overall functionality.

📸 Screenshots

signIn:
Screenshot 2024-10-23 at 2 56 32 PM

signUp:
Screenshot 2024-10-23 at 3 02 15 PM

ENGLISH:
Screenshot 2024-10-23 at 2 55 15 PM

GREEK BEFORE:
Screenshot 2024-10-23 at 2 39 40 PM

GREEK AFTER:
Screenshot 2024-10-23 at 2 55 51 PM
Screenshot 2024-10-23 at 2 56 03 PM

FRENCH:
Screenshot 2024-10-23 at 3 03 02 PM

🪤 Peer Testing

  • lauch the app

to test in english:

  • navigate to signIn, signUp and check the new privacy policy link ( I left some prints showing where its located )
  • after the sigIn go to about screen clicking the button at the bottom of the first screen, scroll down and check the new pricavy policy and terms of service link.

to test in other languages:

  • go to user settings and change the language
  • now perform the same test mentioned before in about page, signIn and SignUp

✏️ Notes

Any question let me know, thanks.

Felipe Imperio added 2 commits October 23, 2024 14:54
…RL into screens ui, adding a proper translations and adding a break lines to greek about translation
Copy link
Member

@andrevitalb andrevitalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@felipeMetaLab felipeMetaLab merged commit c01ea84 into dev Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants