Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize insert from delta file. #19118

Merged

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner January 10, 2025 02:27
@fchirica fchirica added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog DataLayer labels Jan 10, 2025
@fchirica fchirica requested a review from altendky January 10, 2025 02:32
Copy link

coveralls-official bot commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12703103591

Details

  • 48 of 50 (96.0%) changed or added relevant lines in 2 files are covered.
  • 31 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 91.481%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_store.py 25 26 96.15%
chia/data_layer/util/merkle_blob.py 23 24 95.83%
Files with Coverage Reduction New Missed Lines %
chia/timelord/timelord.py 1 80.02%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/server/node_discovery.py 1 81.68%
chia/plotters/plotters.py 1 90.94%
chia/farmer/farmer_api.py 2 94.38%
chia/consensus/blockchain.py 2 94.1%
chia/_tests/core/util/test_lockfile.py 2 89.81%
chia/timelord/timelord_launcher.py 2 89.29%
chia/full_node/weight_proof.py 4 90.64%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 12602516975: -0.01%
Covered Lines: 105451
Relevant Lines: 115083

💛 - Coveralls

Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/data_store.py 96.2% lines 248
chia/data_layer/util/merkle_blob.py 95.8% lines 63
Total Missing Coverage
50 lines 2 lines 96%

@altendky altendky merged commit 128308e into long_lived/datalayer_merkle_blob Jan 10, 2025
302 of 303 checks passed
@altendky altendky deleted the fc.optimize_insert_from_file branch January 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants