Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill in missing rpc client methods #18851

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 12, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

these may well still be missing from the cli as well

@altendky altendky requested a review from a team as a code owner November 12, 2024 15:03
@altendky altendky added Added Required label for PR that categorizes merge commit message as "Added" for changelog Tests Changes to tests labels Nov 12, 2024
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@pmaslana pmaslana merged commit 96a8be8 into main Nov 14, 2024
362 checks passed
@pmaslana pmaslana deleted the fill_in_missing_rpc_client_methods branch November 14, 2024 15:33
altendky added a commit that referenced this pull request Nov 15, 2024
* fill in missing rpc client methods

* no cover

(cherry picked from commit 96a8be8)
cmmarslender pushed a commit that referenced this pull request Nov 21, 2024
* fill in missing rpc client methods

* no cover

(cherry picked from commit 96a8be8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants