Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1734 Annotate spend_bundles as a sequence in WalletSpendBundle's aggregate #18840

Merged

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows us to leverage SpendBundle's aggregate with one extra fix.

Current Behavior:

New Behavior:

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Nov 8, 2024
@AmineKhaldi AmineKhaldi self-assigned this Nov 8, 2024
Copy link
Contributor

@Quexington Quexington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant

@AmineKhaldi AmineKhaldi marked this pull request as ready for review November 8, 2024 21:01
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner November 8, 2024 21:01
@AmineKhaldi AmineKhaldi reopened this Nov 12, 2024
Copy link

Pull Request Test Coverage Report for Build 11806079064

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.965%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/daemon/keychain_proxy.py 1 74.58%
chia/full_node/full_node_api.py 1 82.34%
chia/farmer/farmer.py 1 72.52%
chia/wallet/wallet_node.py 1 88.26%
chia/daemon/client.py 1 73.49%
chia/timelord/timelord_launcher.py 2 90.71%
chia/_tests/core/util/test_lockfile.py 3 88.89%
chia/full_node/full_node.py 11 85.98%
Totals Coverage Status
Change from base Build 11804208692: 0.02%
Covered Lines: 102957
Relevant Lines: 112960

💛 - Coveralls

@pmaslana pmaslana merged commit 2499e97 into Chia-Network:main Nov 14, 2024
710 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants