move get_name_puzzle_conditions() into test utils
#18839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
Changed
arvidn
force-pushed
the
move-get_name_puzzle_conditions
branch
2 times, most recently
from
ee33718 to
cbdd10c
Compare
AmineKhaldi
reviewed
Nov 8, 2024
why? |
It just seemed unnecessary to give it its own module while we have a test utils one about functions related to running blocks. Up to you. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
arvidn
force-pushed
the
move-get_name_puzzle_conditions
branch
from
cbdd10c to
471bbfa
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
|
|
@AmineKhaldi I don't think there's a cost of having one more file, but separating them may avoid module cycles |
AmineKhaldi
approved these changes
Nov 20, 2024
emlowe
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only used by tests now.
Purpose:
reduce the amount of production code.
Current Behavior:
get_name_puzzle_conditions()is only used by tests but live inchia.full_node.mempool_check_conditionsNew Behavior:
get_name_puzzle_conditions()is only used by tests and live inchia._tests.util.get_name_puzzle_conditionsTesting Notes: