Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up ruff ignore list #18837

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Nov 7, 2024

This PR removes as many (mostly) non-controversial ignores from the ruff config as possible and marks some as "probably should be removed" so no one else has to do that exploration later on. The main controversy might be that Ruff enforces that membership checks using in are checked against set literals like {foo, bar}. This causes a problem for some non-hashable types but overall shouldn't be too much of a struggle and helps with overall code consistency.

@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 7, 2024
ruff.toml Outdated Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/full_node/weight_proof.py Show resolved Hide resolved
chia/full_node/weight_proof.py Show resolved Hide resolved
chia/data_layer/s3_plugin_service.py Show resolved Hide resolved
chia/consensus/constants.py Outdated Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
@Quexington Quexington marked this pull request as ready for review November 7, 2024 23:40
@Quexington Quexington requested a review from a team as a code owner November 7, 2024 23:40
@Quexington Quexington requested review from altendky and emlowe November 7, 2024 23:40
emlowe
emlowe previously approved these changes Nov 8, 2024
@emlowe
Copy link
Contributor

emlowe commented Nov 8, 2024

Coverage exemption

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 12, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 12, 2024
@altendky altendky dismissed their stale review November 12, 2024 17:31

concerns addressed

Copy link
Contributor

Copy link

Pull Request Test Coverage Report for Build 11801163556

Details

  • 123 of 143 (86.01%) changed or added relevant lines in 78 files are covered.
  • 35 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/cmds_util.py 0 1 0.0%
chia/cmds/plotnft.py 0 1 0.0%
chia/data_layer/data_layer.py 0 1 0.0%
chia/data_layer/s3_plugin_service.py 0 1 0.0%
chia/plot_sync/sender.py 0 1 0.0%
chia/plotters/plotters_util.py 0 1 0.0%
chia/rpc/crawler_rpc_api.py 0 1 0.0%
chia/rpc/timelord_rpc_api.py 0 1 0.0%
chia/seeder/dns_server.py 0 1 0.0%
chia/server/server.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/daemon/keychain_proxy.py 1 74.58%
chia/util/config.py 1 84.62%
chia/rpc/rpc_server.py 1 87.67%
chia/farmer/farmer.py 1 72.52%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/plotters/madmax.py 1 50.6%
chia/daemon/client.py 1 73.49%
chia/_tests/core/test_farmer_harvester_rpc.py 2 97.95%
chia/util/task_timing.py 3 22.69%
Totals Coverage Status
Change from base Build 11800953276: -0.02%
Covered Lines: 102907
Relevant Lines: 112959

💛 - Coveralls

@pmaslana pmaslana merged commit 6c90a76 into main Nov 12, 2024
361 of 362 checks passed
@pmaslana pmaslana deleted the quex.explore_removing_pylint_ignores branch November 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants