-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor pre_validate_blocks_multiprocessing #18469
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without my proposed changes, the failure results in throwing an IndexError
, rather than the expected INVALID_PREV_BLOCK_HASH
error return value
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
you might want to rebase on top of |
|
Pull Request Test Coverage Report for Build 10743333697Details
💛 - Coveralls |
@arvidn @almogdepaz Is it ok to remove the coverage_diff label and merge? |
Purpose:
this pr simplifies pre_validate_blocks_multiprocessing by passing in the prev sub epoch block the sub slot iters and the difficulty, moving the calls to get_next_sub_slot_iters_and_difficulty outside
this means that the sub slot iters and difficulty are not validates inside pre_validate_blocks_multiprocessing so we still need to call get_next_sub_slot_iters_and_difficulty and compare once every epoch since that is the place in the code where we validate the sub slot iters and the difficulty using the timestamps from the chain
New Behavior:
no change to behavior
Testing Notes: