Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug prints from DID's test_creation_from_coin_spend and test_create_did_with_recovery_list #17152

Merged

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 22, 2023
@AmineKhaldi AmineKhaldi self-assigned this Dec 22, 2023
@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 22, 2023 17:36
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 22, 2023 17:36
@arvidn
Copy link
Contributor

arvidn commented Dec 22, 2023

why should these be removed?

@AmineKhaldi
Copy link
Contributor Author

why should these be removed?

When you run tests locally, these prints result in massive dumps that completely mess up your terminal output without providing anything informative whatsoever. They're clearly meant as temporary prints in order to create the nearby test asserts but were forgotten afterwards.

@altendky altendky requested a review from arvidn December 23, 2023 03:13
@Starttoaster Starttoaster merged commit 456d98b into Chia-Network:main Jan 3, 2024
261 checks passed
mikehw pushed a commit to mikehw/chia-blockchain that referenced this pull request Jan 11, 2024
…_create_did_with_recovery_list (Chia-Network#17152)

Remove debug prints from DID's test_creation_from_coin_spend and test_create_did_with_recovery_list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants