Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't verify right after signing, and as a result don't re-verify the aggregated version, in sign_coin_spends #17143

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Don't verify right after signing, and as a result don't re-verify the aggregated version, in sign_coin_spends #17143

merged 1 commit into from
Dec 27, 2023

Conversation

AmineKhaldi
Copy link
Contributor

This (and the branch name) is dedicated to @emlowe

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 22, 2023
@AmineKhaldi AmineKhaldi self-assigned this Dec 22, 2023
@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 22, 2023 13:27
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 22, 2023 13:27
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7299375627

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.558%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/dl_wallet_store.py 1 95.74%
chia/timelord/timelord_launcher.py 1 69.77%
tests/util/setup_nodes.py 1 98.35%
chia/data_layer/data_layer_wallet.py 2 90.98%
chia/wallet/wallet_node.py 2 87.72%
chia/plotters/madmax.py 3 48.77%
chia/full_node/full_node.py 6 84.54%
chia/server/node_discovery.py 9 78.01%
Totals Coverage Status
Change from base Build 7296031190: 0.1%
Covered Lines: 93976
Relevant Lines: 103747
💛 - Coveralls

emlowe
emlowe approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much love to my good friend Amine ❤️

@cmmarslender cmmarslender merged commit 1f060d4 into Chia-Network:main Dec 27, 2023
173 checks passed
mikehw pushed a commit to mikehw/chia-blockchain that referenced this pull request Jan 11, 2024
@AmineKhaldi @mikehw
Don't verify right after signing, and as a result don't re-verify the…
e941e5f 
… aggregated version, in sign_coin_spends (Chia-Network#17143)

Don't verify right after signing, and as a result don't re-verify the aggregated version, in sign_coin_spends.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineKhaldi @emlowe @cmmarslender