enable ssl_context deprecation warning and fix it (#17127)

* enable ssl_context deprecation warning and fix it

* one case

* a few more

* yup

* one more

chia/daemon/client.py

@@ -43,7 +43,7 @@ async def start(self) -> None:
                 autoclose=True,
                 autoping=True,
                 heartbeat=self.heartbeat,
-                ssl_context=self.ssl_context,
+                ssl=self.ssl_context,
                 max_msg_size=self.max_message_size,
             )
         except Exception:

chia/daemon/keychain_proxy.py

@@ -110,7 +110,7 @@ async def connect_to_keychain(self) -> None:
                     autoclose=True,
                     autoping=True,
                     heartbeat=self.heartbeat,
-                    ssl_context=self.ssl_context,
+                    ssl=self.ssl_context,
                     max_msg_size=self.max_message_size,
                 )
                 await self.listener()

chia/rpc/rpc_client.py

@@ -80,7 +80,7 @@ async def create_as_context(
             await self.await_closed()
 
     async def fetch(self, path, request_json) -> Dict[str, Any]:
-        async with self.session.post(self.url + path, json=request_json, ssl_context=self.ssl_context) as response:
+        async with self.session.post(self.url + path, json=request_json, ssl=self.ssl_context) as response:
             response.raise_for_status()
             res_json = await response.json()
             if not res_json["success"]:

chia/rpc/rpc_server.py

@@ -376,7 +376,7 @@ async def inner() -> None:
                         autoclose=True,
                         autoping=True,
                         heartbeat=self.daemon_heartbeat,
-                        ssl_context=self.ssl_client_context,
+                        ssl=self.ssl_client_context,
                         max_msg_size=max_message_size,
                     )
                     await self.connection(self.websocket)

pytest.ini

@@ -16,7 +16,6 @@ testpaths = tests
 filterwarnings =
     error
     ignore:JSON contains both `coin_solutions` and `coin_spends`, just use `coin_spends`
-    ignore:ssl_context is deprecated:DeprecationWarning
     ignore:Implicitly cleaning up:ResourceWarning
     ignore:unclosed <socket\.socket:ResourceWarning
     ignore:Unclosed client session:ResourceWarning

tests/core/daemon/test_daemon.py

@@ -420,7 +420,7 @@ async def test_daemon_passthru(get_daemon, bt):
             f"wss://127.0.0.1:{daemon_port}",
             autoclose=True,
             autoping=True,
-            ssl_context=bt.get_daemon_ssl_context(),
+            ssl=bt.get_daemon_ssl_context(),
             max_msg_size=100 * 1024 * 1024,
         ) as ws:
             service_name = "test_service_name"

tests/core/daemon/test_daemon_register.py

@@ -21,7 +21,7 @@ async def test_multiple_register_same(get_daemon: WebSocketServer, bt: BlockTool
             f"wss://127.0.0.1:{daemon_port}",
             autoclose=True,
             autoping=True,
-            ssl_context=bt.get_daemon_ssl_context(),
+            ssl=bt.get_daemon_ssl_context(),
             max_msg_size=100 * 1024 * 1024,
         ) as ws:
             service_name = "test_service"
@@ -48,7 +48,7 @@ async def test_multiple_register_different(get_daemon: WebSocketServer, bt: Bloc
             f"wss://127.0.0.1:{daemon_port}",
             autoclose=True,
             autoping=True,
-            ssl_context=bt.get_daemon_ssl_context(),
+            ssl=bt.get_daemon_ssl_context(),
             max_msg_size=100 * 1024 * 1024,
         ) as ws:
             test_service_names = ["service1", "service2", "service3"]
@@ -84,7 +84,7 @@ async def test_remove_connection(get_daemon: WebSocketServer, bt: BlockTools) ->
             f"wss://127.0.0.1:{daemon_port}",
             autoclose=True,
             autoping=True,
-            ssl_context=bt.get_daemon_ssl_context(),
+            ssl=bt.get_daemon_ssl_context(),
             max_msg_size=100 * 1024 * 1024,
         ) as ws:
             test_service_names = ["service1", "service2", "service3", "service4", "service5"]

tests/simulation/test_simulation.py

@@ -162,7 +162,7 @@ async def verify_daemon_connection(daemon: WebSocketServer, service: str) -> boo
                 f"wss://127.0.0.1:{full_system.daemon.daemon_port}",
                 autoclose=True,
                 autoping=True,
-                ssl_context=bt.get_daemon_ssl_context(),
+                ssl=bt.get_daemon_ssl_context(),
                 max_msg_size=100 * 1024 * 1024,
             )
             service_name = "test_service_name"