Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notify job for release.yml (AST-0000) #306

Merged
merged 19 commits into from
Jan 28, 2025
Merged

Conversation

AlvoBen
Copy link
Contributor

@AlvoBen AlvoBen commented Jan 28, 2025

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Copy link

github-actions bot commented Jan 28, 2025

Logo
Checkmarx One – Scan Summary & Details1d345719-aa3a-4a81-99ac-dcbd85960ff7

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /release.yml: 146
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@AlvoBen AlvoBen changed the title Enhance release workflow to extract and output CLI version (AST-0000) And notify job for release.yml (AST-0000) Jan 28, 2025
@AlvoBen AlvoBen changed the title And notify job for release.yml (AST-0000) Add notify job for release.yml (AST-0000) Jan 28, 2025
Comment on lines 154 to 162
- name: Echo tag name to outputs
id: set_tag_name
run: |
echo "::set-output name=TAG_NAME::${{ env.GH_RELEASE_TAG_NAME }}"

- name: Echo CLI version to outputs
id: extract_cli_version
run: |
echo "::set-output name=CLI_VERSION::${{ env.CLI_VERSION }}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be merged to one step

@@ -0,0 +1,54 @@
#!/bin/bash

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets think about moving this script to the new workflow repo and add it as an action there - extract-cli-version that will get the repo type and will know how to search for it in each kind of repo.
this is for our next steps.

@AlvoBen AlvoBen merged commit e2bfe6d into main Jan 28, 2025
10 of 12 checks passed
@AlvoBen AlvoBen deleted the other/benalvo/add-notify-step branch January 28, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants