-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notify job for release.yml (AST-0000) #306
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
|
.github/workflows/release.yml
Outdated
- name: Echo tag name to outputs | ||
id: set_tag_name | ||
run: | | ||
echo "::set-output name=TAG_NAME::${{ env.GH_RELEASE_TAG_NAME }}" | ||
|
||
- name: Echo CLI version to outputs | ||
id: extract_cli_version | ||
run: | | ||
echo "::set-output name=CLI_VERSION::${{ env.CLI_VERSION }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be merged to one step
@@ -0,0 +1,54 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets think about moving this script to the new workflow repo and add it as an action there - extract-cli-version that will get the repo type and will know how to search for it in each kind of repo.
this is for our next steps.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist