Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains Plugin | Implement ASCA Engine (AST-69534) #284

Merged
merged 40 commits into from
Nov 11, 2024

Conversation

AlvoBen
Copy link
Contributor

@AlvoBen AlvoBen commented Oct 10, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Implement ASCA engine in Jetbrains plugin.

References

https://checkmarx.atlassian.net/browse/AST-69534

Testing

Added unitest and UI tests

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Copy link

github-actions bot commented Oct 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsc7cbb0fa-ef2f-4336-8200-b53d31272a5a

No New Or Fixed Issues Found

Copy link

gitguardian bot commented Nov 4, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11482444 Triggered Username Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482449 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482445 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482446 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482450 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482451 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482443 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
11482448 Triggered Generic Password aff6ac9 src/test/java/com/checkmarx/intellij/standard/data/python-vul-file.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@AlvoBen AlvoBen changed the title add asca checkbox and description JetBrains Plugin | Implement ASCA Engine (AST-69534) Nov 4, 2024
OrShamirCM
OrShamirCM previously approved these changes Nov 5, 2024
OrShamirCM
OrShamirCM previously approved these changes Nov 5, 2024
@AlvoBen AlvoBen merged commit 2a5c462 into main Nov 11, 2024
6 checks passed
@AlvoBen AlvoBen deleted the feature/benalvo/asca-impl branch November 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants