Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains | add threshold check (AST-47968) #264

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

AlvoBen
Copy link
Contributor

@AlvoBen AlvoBen commented Aug 12, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Add threshold validation in cx one scan github action

References

https://checkmarx.atlassian.net/browse/AST-47968

Testing

X

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Copy link

github-actions bot commented Aug 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsef2ee4c1-7186-433e-87cf-bbe3d9af3cbf

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@AlvoBen AlvoBen requested a review from a team August 12, 2024 13:52
@@ -22,4 +22,4 @@ jobs:
cx_tenant: ${{ secrets.AST_RND_SCANS_TENANT }}
cx_client_id: ${{ secrets.AST_RND_SCANS_CLIENT_ID }}
cx_client_secret: ${{ secrets.AST_RND_SCANS_CLIENT_SECRET }}
additional_params: --tags phoenix --file-include *.gradle,gradlew --threshold "sca-high=1;sca-medium=1;sca-low=1"
additional_params: --tags phoenix --file-include *.gradle,gradlew --threshold "sca-high=1;sca-medium=1;sca-low=1;sast-high=1;sast-medium=1;sast-low=1;iac-security-high=1;iac-security-medium=1;iac-security-low=1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add critical as well

OrShamirCM
OrShamirCM previously approved these changes Aug 12, 2024
Copy link
Contributor

@OrShamirCM OrShamirCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just add critical too

@AlvoBen AlvoBen merged commit cc3cb51 into main Aug 13, 2024
6 checks passed
@AlvoBen AlvoBen deleted the benalvo/add-threshold-check branch August 13, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants