switch from mocha to node --test
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See current docs: https://nodejs.org/api/test.html |
|
The new test output is much better 👍🏻 Could you please check how test failures are reported? IIRC, the last time we tried, the built-in test runner reported test failures in TAP format, which was difficult for humans to read. |
bajtos
reviewed
Mar 25, 2024
| @@ -2,6 +2,7 @@ import { createHandler } from '../index.js' | |||
| import http from 'node:http' | |||
| import { once } from 'node:events' | |||
| import assert from 'node:assert' | |||
| import { describe, it, before, after } from 'node:test' | |||
also nicer now |
bajtos
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node.js test runner received some significant DX improvements. Test output is now this:
In comparison, with mocha:
The stdlib test runner is continuously receiving improvements and new features, so I think it's the more future ready version. Wdyt @bajtos? In order to evaluate this better, I'm also happy to port a more complicated test suite.