refactor: simplify handling of '//' in req.url #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <[email protected]>
| // Fix the edge case: new URL('//foo', 'http://127.0.0.1') produces href "http://foo/" | ||
| const reqUrl = req.url.replace(/^\/+/, '/') | ||
| const { pathname, searchParams } = new URL(reqUrl, 'http://127.0.0.1') | ||
| // Caveat! `new URL('//foo', 'http://127.0.0.1')` would produce "http://foo/" - not what we want! |
There was a problem hiding this comment.
What do you think about removing the comment and adding a test for this instead? To me that's the programming native version of this solution
There was a problem hiding this comment.
We already have a test in place, I added it in #6.
I suppose I can add another test to verify now we handle an existing route with double-slash.
I prefer to keep the comment to remind readers why we are using string concatenation instead of new URL(path, base). In my experience, it's better to be explicit.
juliangruber
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #6 (comment)