feat: setup CORS to allow all origins #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <[email protected]>
juliangruber
requested changes
Jan 17, 2024
| @@ -86,6 +86,8 @@ export const today = () => getDayAsISOString(new Date()) | |||
| * @param {(import('pg').Pool, import('./typings').Filter) => Promise<object[]>} fetchStatsFn | |||
| */ | |||
| const getStatsWithFilterAndCaching = async (pathname, searchParams, res, pgPool, fetchStatsFn) => { | |||
| res.setHeader('access-control-allow-origin', '*') | |||
There was a problem hiding this comment.
I believe browsers disallow *, and we need to return a hostname instead. I propose to ditch this feature until we can do it proper, with tests etc
There was a problem hiding this comment.
IIUC the docs in MDN, * is allowed only for requests with no credentials. I think we should be fine here.
I propose to ditch this feature until we can do it proper, with tests etc
Agreed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows single-page applications to query our stats. I thought I would need this for our public Grafana Dashboard, so that it can fetch data from the browser. At the end, I found a different option, so this is not strictly needed. But it can be useful as it allows our community to build their own visualisations from our stats.