Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimise SQL query in observeRetrievalResultCodes #316

Merged
merged 2 commits into from
Feb 12, 2025
Merged

perf: optimise SQL query in observeRetrievalResultCodes #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f06697
perf: optimise SQL query in observeRetrievalResultCodes
bajtos Feb 11, 2025
8ed53bc
Merge branch 'main' into perf-update-result-codes
bajtos Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions observer/lib/observer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export const observeRetrievalResultCodes = async (pgPoolStats, influxQueryApi) =
// Ref: https://github.com/filecoin-station/spark-stats/pull/244#discussion_r1824808007
// Note: Having a bucket retention policy is important for this query not to
// time out.
/** @type {{_time: string; _field: string; _value: number}[]} */
const rows = await influxQueryApi.collectRows(`
import "strings"
from(bucket: "spark-evaluate")
Expand All @@ -116,16 +117,16 @@ export const observeRetrievalResultCodes = async (pgPoolStats, influxQueryApi) =
|> keep(columns: ["_value", "_time", "_field"])
|> map(fn: (r) => ({ r with _field: strings.replace(v: r._field, t: "result_rate_", u: "", i: 1) }))
`)
for (const row of rows) {
await pgPoolStats.query(`
INSERT INTO daily_retrieval_result_codes
(day, code, rate)
VALUES ($1, $2, $3)
ON CONFLICT (day, code) DO UPDATE SET rate = EXCLUDED.rate
`, [
row._time,
row._field,
row._value
])
}
console.log('Inserting %s rows to daily_retrieval_result_codes ', rows.length)

await pgPoolStats.query(`
INSERT INTO daily_retrieval_result_codes
(day, code, rate)
VALUES (unnest($1::DATE[]), unnest($2::TEXT[]), unnest($3::NUMERIC[]))
ON CONFLICT (day, code) DO UPDATE SET rate = EXCLUDED.rate
`, [
rows.map(r => r._time),
rows.map(r => r._field),
rows.map(r => r._value)
])
}