Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GET /deals/summary #161

Merged
merged 5 commits into from
Jun 24, 2024
Merged

feat: GET /deals/summary #161

merged 5 commits into from
Jun 24, 2024

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 21, 2024

Return a summary of deals for the selected interval. These values are a bit difficult to calculate on the Grafana side, but I find it easier to build them on our backend.

{
  total: '6900',
  indexed: '709',
  retrievable: '69'
}

Links:

Screenshot from our internal dashboard to illustrate what I am trying to achieve:

Screenshot 2024-06-21 at 17 54 49

Return a summary of deals for the selected interval, the last day,
the last seven days and the last month.

These values are a bit difficult to calculate on the Grafana side,
I find it easier to build them in our backend.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos requested a review from juliangruber June 21, 2024 15:49
@bajtos bajtos merged commit e0d1ca2 into main Jun 24, 2024
10 checks passed
@bajtos bajtos deleted the feat-deals-summary branch June 24, 2024 12:21
@bajtos
Copy link
Member Author

bajtos commented Jun 24, 2024

@juliangruber hindsight please 🙏🏻

Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants