-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX:implemented depenabot #9
base: main
Are you sure you want to change the base?
Conversation
implemented depenabot for both npm and github-action packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR 🎉
Could you also add me (@pyropy) and @NikolasHaimerl to reviewers? 🙏🏻
You are welconme, i have added pyropy and NikolasHaimerl as reviewers as requested |
Awesome @Goddhi! 🚀 Would you mind adding other dependabot related script, like the ones found in spark-stats repository? |
I've added the script you mentioned, along with the Dependabot auto-merge script. Let me know if you'd like me to replicate it across all CheckerNetwork repositories that use Dependabot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're almost there, good job 👏🏻
.github/workflows/deploy.yaml
Outdated
@@ -0,0 +1,33 @@ | |||
name: Deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've copied this on accident. We do already have ci.yml used for deployment. Can you please delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted the deploy file as suggested.
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
- name: Approve a PR | ||
run: gh pr review --approve "$PR_URL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the script in spark-stats repository I've previously linked this script and the script in the mentioned repository differ quite a bit.
We would need to add a statement to only auto-approve minor version upgrades, rather than all upgrades.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have implemented it, kindly review it. thanks.
implemented depenabot for both npm and github-action packages.