Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:implemented depenabot #9

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Goddhi
Copy link

@Goddhi Goddhi commented Feb 23, 2025

implemented depenabot for both npm and github-action packages.

implemented depenabot for both npm and github-action packages
@Goddhi Goddhi requested a review from pyropy as a code owner February 23, 2025 10:56
Copy link
Collaborator

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR 🎉

Could you also add me (@pyropy) and @NikolasHaimerl to reviewers? 🙏🏻

@Goddhi
Copy link
Author

Goddhi commented Feb 24, 2025

You are welconme, i have added pyropy and NikolasHaimerl as reviewers as requested

@pyropy
Copy link
Collaborator

pyropy commented Feb 25, 2025

Awesome @Goddhi! 🚀

Would you mind adding other dependabot related script, like the ones found in spark-stats repository?
Note: We'd like to use this dependabot-auto-merge.yml script.

@Goddhi
Copy link
Author

Goddhi commented Feb 26, 2025

I've added the script you mentioned, along with the Dependabot auto-merge script. Let me know if you'd like me to replicate it across all CheckerNetwork repositories that use Dependabot.

Copy link
Collaborator

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're almost there, good job 👏🏻

@@ -0,0 +1,33 @@
name: Deploy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've copied this on accident. We do already have ci.yml used for deployment. Can you please delete this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted the deploy file as suggested.

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
- name: Approve a PR
run: gh pr review --approve "$PR_URL"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the script in spark-stats repository I've previously linked this script and the script in the mentioned repository differ quite a bit.

We would need to add a statement to only auto-approve minor version upgrades, rather than all upgrades.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have implemented it, kindly review it. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants