Add HTTP HEAD results. CheckerNetwork/spark-checker#104 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
had a problem deploying
to
default
GitHub Actions
Failure
This was referenced Feb 28, 2025
Deploying spark-dashboard with
|
| Latest commit: |
879d761
|
| Status: | 🚫 Build failed. |
juliangruber
had a problem deploying
to
default
GitHub Actions
Failure
juliangruber
had a problem deploying
to
default
GitHub Actions
Failure
The metric currently is at 0, which is why it doesn't show up yet |
juliangruber
changed the title
successful_http_head. CheckerNetwork/spark-checker#104
| @@ -12,6 +12,12 @@ export function Histogram(events, { width, title, thresholds }) { | |||
| if (d.success_rate_http != null) { | |||
| res.push({ type: 'HTTP only', value: d.success_rate_http * 100 }) | |||
| } | |||
| if (d.success_rate_http_head != null) { | |||
There was a problem hiding this comment.
Is d.success_rate_http_head===undefined a possibility too?
Should we wait for a final review until enough data is available so we can see the visualization? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CheckerNetwork/spark-checker#104
Blocked by CheckerNetwork/spark-stats#322