fix: deduplicate list of clients in retrieval tasks #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we discovered that there is a lot of deals using the same payload CID `bafkqaaa`. There are more than 22k deals, but only between 27 miners and 9 clients. As a result, when one of such deals is picked for testing, the list of clients is very long and full of duplicates. In this change, I am modifying the query sampling eligible deals to de-duplicate the list of clients in each task. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
requested review from
juliangruber,
pyropy and
NikolasHaimerl
as code owners
bajtos
commented
Feb 10, 2025
bajtos
commented
Feb 10, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
juliangruber
approved these changes
Feb 10, 2025
Signed-off-by: Miroslav Bajtoš <[email protected]>
Fixed in 739fc1c. My new test was affecting other test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we discovered that there is a lot of deals using the same payload CID
bafkqaaa. There are more than 22k deals, but only between 27 miners and 9 clients. As a result, when one of such deals is picked for testing, the list of clients is very long and full of duplicates.Example:
https://api.filspark.com/rounds/meridian/0x8460766edc62b525fc1fa4d628fc79229dc73031/25039
In this change, I am modifying the query sampling eligible deals to de-duplicate the list of clients in each task.