Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device.py #22

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Update device.py #22

merged 1 commit into from
Feb 9, 2018

Conversation

luca-angemi
Copy link
Contributor

Using the new notification API, the ContentItem tag is absent in the xml_dom.

Using the new notification API, the ContentItem tag is absent in the xml_dom.
@coveralls
Copy link

coveralls commented Feb 8, 2018

Coverage Status

Coverage increased (+0.002%) to 99.481% when pulling f39f824 on luca-angemi:master into bb57bc8 on CharlesBlonde:master.

@CharlesBlonde
Copy link
Owner

Thanks for this PR!
I'll merge it and fix the build in the master branch

@CharlesBlonde CharlesBlonde merged commit 8ec2dd2 into CharlesBlonde:master Feb 9, 2018
@luca-angemi
Copy link
Contributor Author

Cheers!

@luca-angemi
Copy link
Contributor Author

Any plan to make a new release soon? Could be helpful to Home Assistant people using TTS.

@CharlesBlonde
Copy link
Owner

I'm working on it :)
I hope I'll be able to release a new version a submit a PR to Home Assistant this WE.
But I would like to be able to do some tests on this feature request #21 before.

@luca-angemi
Copy link
Contributor Author

That's great. I read your latest comment on #21 and yes, the user will need to get a Key and the requests unfortunately are limited to 100/day. I tested as well and it works pretty well with TTS integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants