YAML validation #3790
Merged
YAML validation #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IP validation regex had a couple of silly bugs -- finally properly tested
There is no lena.ns.cloudflare.com; maybe this was supposed to be Art+Lana? (Only one hit, in October 2019 -- the watch was from early December.)
|
The test currently adds about 45 seconds to the duration of the test suite. Maybe it should be hacked to run only at the end. |
|
The CI test failure looks spurious; I sometimes get this on my laptop, too. Will rebase and re-push and hope it works this time. |
blacklists.py: refactor slightly to facilitate validation
tripleee
force-pushed
the
yaml-validation
branch
from
1d47c69 to
0d1fdd6
Compare
ArtOfCode-
reviewed
Apr 4, 2020
watched_nses.yml
Outdated
| @@ -516,7 +513,9 @@ items: | |||
| ns: mihanwebhost.com. | |||
| - ns: offshoreracks.com. | |||
| - ns: sathyats.net. | |||
| - ns: shared-host.org. | |||
| - comment: no longert responding 2020-04-02 | |||
There was a problem hiding this comment.
You've substituted typos in NSes to typos in comments :)
There was a problem hiding this comment.
Thanks for noticing, I'll fix and merge on Monday.
ArtOfCode-
approved these changes
Apr 4, 2020
Special case "pass: true" for recent freak addition; probably remove the code in blacklists.py to support this case if it goes away
tripleee
force-pushed
the
yaml-validation
branch
from
030224f to
9e95c14
Compare
|
See also now #3793. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case to check the YAML lists for some simple problems.
Testing revealed a number of issues which are also solved with this PR.
The commented-out entries should probably be removed eventually, but some of the issues may be transient, so I want to keep them around and revisit them in a few weeks.