-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for blacklisting a user network-wide #13994
base: master
Are you sure you want to change the base?
Support for blacklisting a user network-wide #13994
Conversation
I guess the new commands should be added to the wiki once this PR is merged. |
How does this look?
|
This looks fine for me but I am not at all involved with maintaining anything in this repository at all. |
(List from here)
This PR resolves #6845 by adding support for blacklisting a user network-wide.
See #6845.
I tried to, although I didn't include the why, seeing as it's here and in the linked issue.
I've added some comments where it seemed appropriate.
I think I did, but I'm open to suggested changes (on anything here, of course, not just the variable names).
I've updated some existing tests to handle the changed phrasing, although I haven't added tests to cover the added functionality. I've been testing my changes in this room, which includes the changes that don't have tests.
For this PR:
Post
class. It may be preferable to instead use the change(s) Makyen describes here instead.addblu
andrmblu
text to note a network-wide blacklist.isblu
text based on if they're (a) on the site blacklist & (b) if they're on the network-wide blacklistcheck_if_spam
function - not sure if I did that correctlyNot in this PR - these may be reasonable to implement; however, to reduce scope of this PR, I'm postponing them,
isblu
should list site blacklists when checking a SE account - e.g., doing!!/isblu https://stackexchange.com/users/<someone>
would also list and sites that<someone>
blacklisted onaddblu
andrmblu
to note if a user is already network-wide blacklisted if changing a site blacklistNote that I wasn't seeing the
account_id
with the existing filter,. I'm not sure why, so I changed it for testing, but I (or someone else) should investigate.