fix: resolve React warnings and accessibility issues

cypress/e2e/command/spec.cy.ts

@@ -17,7 +17,9 @@ describe('Command', () => {
 
     cy.get("#command-button").should("exist")
 
-    cy.get(".step").eq(1).should("have.text", "Command: Search")
+    cy.get(".step").eq(1).invoke('text').then((text) => {
+      expect(text.trim()).to.equal("Command: Search")
+    })
 
     cy.get(`#chat-input`).type("/pic")
     cy.get(".command-item").should('have.length', 1);

frontend/src/App.tsx

@@ -38,29 +38,31 @@ function App() {
     : false;
 
   useEffect(() => {
-    if (!isAuthenticated || !isReady) {
+    if (!isAuthenticated || !isReady || !chatProfileOk) {
       return;
-    } else if (!chatProfileOk) {
-      return;
-    } else {
-      connect({
-        transports: window.transports,
-        userEnv
-      });
     }
+
+    connect({
+      transports: window.transports,
+      userEnv
+    });
   }, [userEnv, isAuthenticated, connect, isReady, chatProfileOk]);
 
-  if (configLoaded && config.chatProfiles.length && !chatProfile) {
-    // Autoselect the first default chat profile
+  useEffect(() => {
+    if (!configLoaded || !config || !config.chatProfiles?.length || chatProfile) {
+      return;
+    }
+
     const defaultChatProfile = config.chatProfiles.find(
       (profile) => profile.default
     );
+
     if (defaultChatProfile) {
       setChatProfile(defaultChatProfile.name);
     } else {
       setChatProfile(config.chatProfiles[0].name);
     }
-  }
+  }, [configLoaded, config, chatProfile, setChatProfile]);
 
   if (!configLoaded && isAuthenticated) return null;
 

frontend/src/components/LeftSidebar/ThreadList.tsx

@@ -274,32 +274,32 @@ export function ThreadList({
                   isResumed || threadHistory.currentThreadId === thread.id;
                 return (
                   <SidebarMenuItem key={thread.id} id={`thread-${thread.id}`}>
-                    <Link to={isResumed ? '' : `/thread/${thread.id}`}>
-                      <SidebarMenuButton
-                        isActive={isSelected}
-                        className="relative truncate h-9 group/thread"
-                      >
-                        {thread.name || (
-                          <Translator path="threadHistory.thread.untitled" />
-                        )}
-                        <div
-                          className={cn(
-                            'absolute w-10 bottom-0 top-0 right-0 bg-gradient-to-l from-[hsl(var(--sidebar-background))] to-transparent'
-                          )}
-                        />
-                        <ThreadOptions
-                          onDelete={() => setThreadIdToDelete(thread.id)}
-                          onRename={() => {
-                            setThreadIdToRename(thread.id);
-                            setThreadNewName(thread.name);
-                          }}
-                          className={cn(
-                            'absolute z-20 bottom-0 top-0 right-0 bg-sidebar-accent hover:bg-sidebar-accent hover:text-primary flex opacity-0 group-hover/thread:opacity-100',
-                            isSelected && 'bg-sidebar-accent opacity-100'
+                    <div className="relative">
+                      <Link to={isResumed ? '' : `/thread/${thread.id}`}>
+                        <SidebarMenuButton
+                          isActive={isSelected}
+                          className="relative truncate h-9 group/thread pr-10" // 添加右边距给 ThreadOptions 留空间
+                        >
+                          {thread.name || (
+                            <Translator path="threadHistory.thread.untitled" />
                           )}
-                        />
-                      </SidebarMenuButton>
-                    </Link>
+                          <div className={cn(
+                            'absolute w-10 bottom-0 top-0 right-0 bg-gradient-to-l from-[hsl(var(--sidebar-background))] to-transparent'
+                          )} />
+                        </SidebarMenuButton>
+                      </Link>
+                      <ThreadOptions
+                        onDelete={() => setThreadIdToDelete(thread.id)}
+                        onRename={() => {
+                          setThreadIdToRename(thread.id);
+                          setThreadNewName(thread.name);
+                        }}
+                        className={cn(
+                          'absolute z-20 right-0 top-0 h-full bg-sidebar-accent hover:bg-sidebar-accent hover:text-primary flex opacity-0 group-hover/thread:opacity-100',
+                          isSelected && 'bg-sidebar-accent opacity-100'
+                        )}
+                      />
+                    </div>
                   </SidebarMenuItem>
                 );
               })}

frontend/src/components/LeftSidebar/ThreadOptions.tsx

@@ -2,7 +2,7 @@ import { cn } from '@/lib/utils';
 import { Ellipsis, Trash } from 'lucide-react';
 
 import { Pencil } from '@/components/icons/Pencil';
-import { Button } from '@/components/ui/button';
+import { buttonVariants } from '@/components/ui/button';
 import {
   DropdownMenu,
   DropdownMenuContent,
@@ -25,22 +25,18 @@ export default function ThreadOptions({
 }: Props) {
   return (
     <DropdownMenu>
-      <DropdownMenuTrigger asChild>
-        <Button
-          variant="ghost"
-          size="icon"
-          onClick={(e) => {
-            e.stopPropagation();
-            e.preventDefault();
-          }}
-          id="thread-options"
-          className={cn(
-            'focus:ring-0 focus:ring-offset-0 focus-visible:ring-0 focus-visible:ring-offset-0 text-muted-foreground',
-            className
-          )}
-        >
-          <Ellipsis />
-        </Button>
+      <DropdownMenuTrigger className={cn(
+        buttonVariants({ variant: 'ghost', size: 'icon' }),
+        'focus:ring-0 focus:ring-offset-0 focus-visible:ring-0 focus-visible:ring-offset-0 text-muted-foreground',
+        className
+      )}
+      onClick={(e) => {
+        e.stopPropagation();
+        e.preventDefault();
+      }}
+      id="thread-options"
+      >
+        <Ellipsis />
       </DropdownMenuTrigger>
       <DropdownMenuContent className="w-20" align="start" forceMount>
         <DropdownMenuItem

frontend/src/components/Markdown.tsx

@@ -1,6 +1,6 @@
 import { cn } from '@/lib/utils';
 import { omit } from 'lodash';
-import { useContext, useMemo } from 'react';
+import React, { useContext, useMemo } from 'react';
 import ReactMarkdown from 'react-markdown';
 import { PluggableList } from 'react-markdown/lib';
 import rehypeKatex from 'rehype-katex';
@@ -12,9 +12,11 @@ import { visit } from 'unist-util-visit';
 import { ChainlitContext, type IMessageElement } from '@chainlit/react-client';
 
 import { AspectRatio } from '@/components/ui/aspect-ratio';
+/* eslint-disable-next-line @typescript-eslint/no-unused-vars */
 import { Card } from '@/components/ui/card';
 import { Separator } from '@/components/ui/separator';
 import {
+  /* eslint-disable-next-line @typescript-eslint/no-unused-vars */
   Table,
   TableBody,
   TableCell,
@@ -230,18 +232,18 @@ const Markdown = ({
           );
         },
         p(props) {
-          return (
-            <p
-              {...omit(props, ['node'])}
-              className="leading-7 [&:not(:first-child)]:mt-4 whitespace-pre-wrap break-words"
-            />
+          const containsBlockElement = React.Children.toArray(props.children).some(
+            child => 
+              React.isValidElement(child) && 
+              (/^h[1-6]$/.test((child.type as string)) || child.type === 'p')
           );
-        },
-        table({ children, ...props }) {
-          return (
-            <Card className="[&:not(:first-child)]:mt-2 [&:not(:last-child)]:mb-2">
-              <Table {...(props as any)}>{children}</Table>
-            </Card>
+
+          const commonClassNames = "leading-7 [&:not(:first-child)]:mt-4 whitespace-pre-wrap break-words";
+
+          return containsBlockElement ? (
+            <div {...omit(props, ['node'])} className={commonClassNames} />
+          ) : (
+            <p {...omit(props, ['node'])} className={commonClassNames} />
           );
         },
         thead({ children, ...props }) {

frontend/src/components/chat/Messages/Message/Content/index.tsx

@@ -38,7 +38,7 @@ const MessageContent = memo(
     const isMessage = message.type.includes('message');
 
     const outputMarkdown = (
-      <p className="flex flex-col gap-2">
+      <div className="flex flex-col gap-2">  {/* change to div */}
         {!isMessage && displayInput ? (
           <div className="text-lg font-semibold leading-none tracking-tight">
             Output
@@ -51,7 +51,7 @@ const MessageContent = memo(
         >
           {output}
         </Markdown>
-      </p>
+      </div>
     );
 
     let inputMarkdown;
@@ -73,7 +73,7 @@ const MessageContent = memo(
         });
 
       inputMarkdown = (
-        <p className="flex flex-col gap-2">
+        <div className="flex flex-col gap-2">  {/* change to div */}
           <div className="text-lg font-semibold leading-none tracking-tight">
             Input
           </div>
@@ -84,7 +84,7 @@ const MessageContent = memo(
           >
             {input}
           </Markdown>
-        </p>
+        </div>
       );
     }
 

frontend/src/components/chat/Messages/index.tsx

@@ -1,5 +1,5 @@
 import { MessageContext } from 'contexts/MessageContext';
-import { memo, useContext } from 'react';
+import React, { memo, useContext } from 'react';
 
 import {
   type IAction,
@@ -61,10 +61,9 @@ const Messages = memo(
             const scorableRun =
               !isRunning && m.name !== 'on_chat_start' ? m : undefined;
             return (
-              <>
+              <React.Fragment key={m.id}>
                 {m.steps?.length ? (
                   <Messages
-                    key={m.id}
                     messages={m.steps}
                     elements={elements}
                     actions={actions}
@@ -76,7 +75,7 @@ const Messages = memo(
                 {showToolCoTLoader || showHiddenCoTLoader ? (
                   <BlinkingCursor />
                 ) : null}
-              </>
+              </React.Fragment>
             );
           } else {
             // Score the current run

frontend/src/components/header/ChatProfiles.tsx

@@ -1,5 +1,4 @@
-import { size } from 'lodash';
-import { useContext, useState } from 'react';
+import { useContext, useEffect, useState } from 'react';
 
 import {
   ChainlitContext,
@@ -38,9 +37,11 @@ export default function ChatProfiles({ navigate }: Props) {
   const [newChatProfile, setNewChatProfile] = useState<string | null>(null);
   const [openDialog, setOpenDialog] = useState(false);
 
-  if (!chatProfile && size(config?.chatProfiles) > 0) {
-    setChatProfile(config?.chatProfiles[0].name);
-  }
+  useEffect(() => {
+    if (!chatProfile && config?.chatProfiles && config.chatProfiles.length > 0) {
+      setChatProfile(config?.chatProfiles?.[0]?.name);
+    }
+  }, [chatProfile, config?.chatProfiles, setChatProfile]);
 
   if (typeof config === 'undefined' || config.chatProfiles.length <= 1) {
     return null;
@@ -59,14 +60,6 @@ export default function ChatProfiles({ navigate }: Props) {
     handleClose();
   };
 
-  if (!chatProfile && config?.chatProfiles?.length > 0) {
-    setChatProfile(config.chatProfiles[0].name);
-  }
-
-  if (!config || config.chatProfiles.length <= 1) {
-    return null;
-  }
-
   const allowHtml = config?.features?.unsafe_allow_html;
   const latex = config?.features?.latex;