-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow sending toast notifications #1736
Conversation
67291e9
to
6eb4f4f
Compare
This is looking great! I think we could add a function on the emitter class with typing on top of |
@@ -69,7 +69,7 @@ function App() { | |||
storageKey="vite-ui-theme" | |||
defaultTheme={data?.default_theme} | |||
> | |||
<Toaster className="toast" position="top-right" /> | |||
<Toaster richColors className="toast" position="top-right" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willydouhard I added the richColors settings, let me know what you think, I think it goes quite well with chainlit look
How is this pr going? Can I make a new request as @willydouhard asked for? Related issue #1797 |
It is ready I think to be merged, wdyt @willydouhard @dokterbob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable sending toast notification from chainlit app
Related to #1639
This is my first PR 🥳