feat: non simd sha256 for incompatible systems #427
+20,837
−15,970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: nvm, we haven't used but the wasm code was loaded anyway |
matthewkeil
force-pushed
the
mkeil/non-simd-sha256
branch
from
f55d080 to
bdf755c
Compare
matthewkeil
force-pushed
the
mkeil/non-simd-sha256
branch
from
ddd5c17 to
51b1bdd
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
changed the title
wemeetagain
requested changes
Jan 6, 2025
There was a problem hiding this comment.
You should be able to use WebAssembly.validate to synchronously do "feature detection" and avoid a lot of complexity related to async initialization here.
(It appears that wasm-feature-detect is using WebAssembly.validate under the hood.)
eg:
import {wasmCode} from "./wasmCode.js";
import {wasmSimdCode} from "./wasmSimdCode.js";
const hasSimd = WebAssembly.validate(wasmSimdCode);
const _module = new WebAssembly.Module(hasSimd ? wasmSimdCode : wasmCode);
matthewkeil
changed the title
wemeetagain
reviewed
Jan 7, 2025
| final, | ||
| digest, | ||
| digest64 | ||
| } from "./common"; |
There was a problem hiding this comment.
Add a non-simd implementation of batchHash4UintArray64s and batchHash4HashObjectInputs here (making the interface of simd and non-simd wasm module the same). Then the javascript layer won't need runtime checking and the only refactor there is the module reinitialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An issue was posted about systems that do not support simd feature set. Made library compatible with those systems.
See ChainSafe/lodestar#7177 for more information.
Description of Changes
as-sha25