fix: remove aggregation bits from seen attestation cache #7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Nov 29, 2024
twoeths
reviewed
Nov 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7265 +/- ##
============================================
- Coverage 48.44% 48.42% -0.02%
============================================
Files 602 602
Lines 40321 40332 +11
Branches 2057 2056 -1
============================================
- Hits 19532 19531 -1
- Misses 20751 20763 +12
Partials 38 38 |
ensi321
pushed a commit
that referenced
this pull request
Dec 14, 2024
* fix: remove aggregation bits from seen attestation cache * Allow passing null as aggregationBits to test pre-electra case * Only create aggregationBits once for the first attestation * Avoid second getSingleTrueBit call
ensi321
pushed a commit
that referenced
this pull request
Dec 14, 2024
* fix: remove aggregation bits from seen attestation cache * Allow passing null as aggregationBits to test pre-electra case * Only create aggregationBits once for the first attestation * Avoid second getSingleTrueBit call
ensi321
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: remove aggregation bits from seen attestation cache * Allow passing null as aggregationBits to test pre-electra case * Only create aggregationBits once for the first attestation * Avoid second getSingleTrueBit call
|
🎉 This PR is included in v1.26.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As noted by @twoeths in #7260 (comment), the cache is used for whole committee and not just a single validator which means the cached
aggregationBitswould be incorrect if reused for another attestation from a different validator.Description
Remove aggregation bits from seen attestation cache