Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RUSTSEC-2024-0370 #5152

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: RUSTSEC-2024-0370 #5152

wants to merge 15 commits into from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 17, 2025 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • embed source code of rs-car and rs-car-ipfs with dependency upgrades to resolve RUSTSEC-2024-0370
  • update add_license.sh to ignore src/external/**/*.rs

Reference issue to close (if applicable)

Closes #5068

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 force-pushed the hm/RUSTSEC-2024-0370 branch from 36f28c7 to 6bc3247 Compare January 17, 2025 10:48
@hanabi1224 hanabi1224 force-pushed the hm/RUSTSEC-2024-0370 branch from 6bc3247 to 1525cdd Compare January 17, 2025 10:57
@hanabi1224 hanabi1224 marked this pull request as ready for review January 17, 2025 10:57
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 17, 2025 10:57
@hanabi1224 hanabi1224 requested review from lemmih and LesnyRumcajs and removed request for a team January 17, 2025 10:57
@lemmih
Copy link
Contributor

lemmih commented Jan 20, 2025

Still failing CI.

@hanabi1224
Copy link
Contributor Author

Still failing CI.

@lemmih doc tests fixed(ignored).

@LesnyRumcajs
Copy link
Member

no green checkmark!

@hanabi1224
Copy link
Contributor Author

no green checkmark!

@LesnyRumcajs Now it's green!

LesnyRumcajs
LesnyRumcajs reviewed Jan 21, 2025
View reviewed changes
.config/forest.dic Outdated Show resolved Hide resolved
@lemmih lemmih requested review from sudo-shashank and removed request for lemmih January 23, 2025 09:17
@lemmih
Copy link
Contributor

lemmih commented Jan 23, 2025

I'll pass on reviewing this PR. I'm not sold on the benefits of adding 2k LOC but I won't stand in the way.

@LesnyRumcajs
Copy link
Member

@lemmih What would be your approach?

@lemmih
Copy link
Contributor

lemmih commented Jan 23, 2025

@lemmih What would be your approach?

Pushing the changes upstream to rs-car-ipfs.

@LesnyRumcajs
Copy link
Member

@hanabi1224 should we wait for the changes to be released in those crates, then? @hanabi1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix RUSTSEC-2024-0370
3 participants
@hanabi1224 @lemmih @LesnyRumcajs