chore: update the package name and version #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
requested changes
Dec 9, 2024
package.json
Outdated
| "repository": "[email protected]:dapplion/benchmark.git", | ||
| "author": "dapplion <[email protected]>", | ||
| "name": "@chainsafe/benchmark", | ||
| "version": "0.1.0.rc-0", |
There was a problem hiding this comment.
Suggested change
| "version": "0.1.0.rc-0", | |
| "version": "1.1.0", |
There was a problem hiding this comment.
As it's a new package I would prefer to start with 0 versioning scheme.
There was a problem hiding this comment.
its not a new package though and it was forked from 1.0.0.... if anything it should be 1.1.0 if this is a minor and 2.0.0 if its a major which i dont think it is....
1.1.0 feels like the right number here
nazarhussain
force-pushed
the
nh/package-version
branch
from
5f5bf40 to
fa7aeea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the package name and version for standalone release as
@chainsafe/benchmark.Description
Steps to test or reproduce