Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getPath and setPath methods to the Uri class, fix a bug in joinToString #849

Merged
merged 8 commits into from
Apr 6, 2024

Conversation

kring
Copy link
Member

@kring kring commented Apr 5, 2024

No description provided.

@kring kring changed the title Add getPath and setPath methods to the Uri class Add getPath and setPath methods to the Uri class, fix joinToString Apr 5, 2024
@kring kring changed the title Add getPath and setPath methods to the Uri class, fix joinToString Add getPath and setPath methods to the Uri class, fix a bug in joinToString Apr 5, 2024
Copy link
Contributor

@j9liu j9liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kring I had a few comments but I'll implement them to save you time. If you're happy with the changes then this can be merged!

CesiumUtility/test/TestJoinToString.cpp Show resolved Hide resolved
CesiumUtility/include/CesiumUtility/Uri.h Outdated Show resolved Hide resolved
CesiumUtility/include/CesiumUtility/Uri.h Outdated Show resolved Hide resolved
@j9liu
Copy link
Contributor

j9liu commented Apr 5, 2024

@kring pushed some tweaks. Feel free to merge if happy (unless you want me to hit the button instead)!

@kring
Copy link
Member Author

kring commented Apr 6, 2024

Your changes look great, thanks @j9liu!

@kring kring merged commit b2a1c6d into main Apr 6, 2024
13 of 14 checks passed
@kring kring deleted the uri-path branch April 6, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants