Support for Cesium ion servers running in single-user authentication mode. #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoore
reviewed
Apr 3, 2024
timoore
reviewed
Apr 3, 2024
timoore
reviewed
Apr 3, 2024
| * | ||
| * @return A future that resolves to the application information. | ||
| */ | ||
| static CesiumAsync::Future<Response<ApplicationData>> appData( |
There was a problem hiding this comment.
Kinda think the verb form "getAppData" would be more descriptive.
There was a problem hiding this comment.
This would make sense, but I wanted to keep the naming consistent with the rest of the methods. In this class, all the get* methods return private members of the class, whereas all the methods calling endpoints are named with that endpoint name (me, assets, defaults, etc).
timoore
reviewed
Apr 3, 2024
j9liu
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Looks good to me @azrogers! Not super familiar with the ion code myself, but with respect to everything else in there, it makes sense to me 😄
Just a few nitpick comments. Could you also merge with main and update CHANGES.md for this PR?
j9liu
reviewed
Apr 26, 2024
|
Thanks @azrogers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the box, Cesium ion Self-Hosted is set-up in the single-user authentication mode, which means that it has no accounts or tokens - any request that can reach the server is considered valid. This is a problem for cesium-native and its integrations, which expect Cesium ion to always require a token.
This change is a necessary part of adding this support. It changes cesium-native to allow requesting the active authentication mode from the
/appDataendpoint, and allows Unity and Unreal integrations to access the current authentication mode. It also provides dummy responses for the/meand/tokensendpoints when running in single-user mode, as these endpoints don't exist in the single-user configuration.