Skip to content

Commit

Permalink
Fix compilation errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
kring committed Apr 9, 2024
1 parent 061ccca commit 277359d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2452,7 +2452,7 @@ TEST_CASE("Omits value-less properties when converting "
CHECK(propertyTable.classProperty == "default");

// Verify that all property table properties refer to a valid bufferView.
for (const std::pair<std::string, PropertyTableProperty>& pair :
for (const std::pair<const std::string, PropertyTableProperty>& pair :
propertyTable.properties) {
CHECK(pair.second.values >= 0);
CHECK(size_t(pair.second.values) < gltf.bufferViews.size());
Expand Down
8 changes: 2 additions & 6 deletions CesiumGltfContent/src/GltfUtilities.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,8 @@ struct VisitAccessorIds {

ExtensionCesiumPrimitiveOutline* pPrimitiveOutline =
primitive.getExtension<ExtensionCesiumPrimitiveOutline>();
if (pPrimitiveOutline && pPrimitiveOutline->indices) {
// The `indices` property is incorrectly defined as an int64_t in this
// extension, so we need to jump through some hoops.
int32_t temp = int32_t(*pPrimitiveOutline->indices);
callback(temp);
*pPrimitiveOutline->indices = temp;
if (pPrimitiveOutline) {
callback(pPrimitiveOutline->indices);
}
}
}
Expand Down

0 comments on commit 277359d

Please sign in to comment.