Feature: MP parser frontend scaffolding + API calls #84
Conversation
XanderVertegaal
added
the
minimalist parser
| @@ -123,6 +124,8 @@ | |||
|
|
|||
| SPINDLE_URL = f"http://pp-spindle:32768/" | |||
| LATEX_SERVICE_URL = f"http://pp-latex:32769/" | |||
| MINIMALIST_PARSER_URL = f"http://pp-minimalist-parser:32770/" | |||
There was a problem hiding this comment.
Not in use yet, so don't try to connect to them ;)
| } | ||
|
|
||
|
|
||
| def status_check(service: Literal["spindle", "minimalist_parser", "vulcan"]) -> bool: |
There was a problem hiding this comment.
Hmm yes very functional very nice
|
|
||
| } @else { | ||
| <p class="notification mt-6" i18n> | ||
| The Minimalist Parser is temporarily unavailable. |
There was a problem hiding this comment.
It's important to give your users hope and prospects of a better future ;)
| }); | ||
| } | ||
|
|
||
| public parse(): void { |
There was a problem hiding this comment.
Okay, considering the exportResult function from spindle.component.ts:
public parse(): void {
this.form.controls.mpInput.markAsTouched();
this.form.controls.mpInput.updateValueAndValidity();
const input = this.form.controls.mpInput.value;
if (this.form.invalid || !input) {
return;
}
this.apiService.input$.next(input);
}These functions are very similar: could we think of a good way to make them generalizable / put them in a service? Is that even worthwhile, do you think? I'm happy to let this rest since it's not really priority but I was wondering all the same.
There was a problem hiding this comment.
I definitely there is room to DRY this code a bit more. I've created a new issue for it: #93 .
…orDigitalHumanities/parseport into feature/parser-api-calls
(#81 should be reviewed/merged first.)Done!Some more scaffolding before the actual parser + visualizer are added to the Docker network. This code is mostly a copy/adaptation of what is already in place for Spindle/Aethel.
This PR adds a new Django app
minimalist_parserto backend, with a status check akin to the one in place for thespindleandaethel_dbapps. The idea is that the server can check the other containers in the network to make sure the services are all running, and to notify the frontend if they aren't.Regarding the frontend, this PR expands the MinimalistParserInput component and adds a service to deal with the data fetching.
Next step is to add the containers to the Docker network and try to actually apply the parser to user input!