Feature: replace AgentDescriptionName with EntityDescription.designators #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanderVertegaal
changed the title
lukavdplas
approved these changes
May 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
designatorson theEntityDescriptionmodel, which can be used to record (Latin) terminology used to designate an entity in a source.This makes the
AgentDescriptionNamemodel obsolete, so I removed it.More controversially, I've also removed
FieldDescription.source_terminology, as the researchers' notes suggest that they're recording Latin terminology for entity descriptions in general, not for individual fields. In the general spirit of 'simplify now; re-add complexity when requested', this seems like a good step, but I'd be willing to revert this change if so desired.