Feature/episodes #14
Feature/episodes #14
Conversation
| @@ -4,64 +4,112 @@ | |||
|
|
|||
| class PersonNameAdmin(admin.StackedInline): | |||
| model = models.PersonName | |||
| fields = ['value', 'certainty', 'note'] | |||
|
|
|||
| fields = ["value", "certainty", "note"] | |||
There was a problem hiding this comment.
My editor automatically uses Black. I could turn this off for this project, but it may not be a bad idea to agree on a formatter.
There was a problem hiding this comment.
I personally don't mind formatting inconsistencies, but if you prefer we use the same formatter, I can install it.
There was a problem hiding this comment.
What I do mind is (auto-)formatting an entire file when you're changing a few lines of content. It makes the review more difficult, as meaningful changes get cluttered by meaningless ones.
Anyway, we can choose something in our next meeting. It's a good idea to decide on this early in the project.
There was a problem hiding this comment.
Agreed! In the meantime, I'll turn off Black for this project to avoid large meaningless diffs.
|
|
||
| These can be grouped into epistolary events. | ||
| """ | ||
|
|
||
| letters = models.ManyToManyField( |
There was a problem hiding this comment.
A LetterAction currently contains multiple letters; it inherited this from the old EpistolaryEvent model. What would you say if we made this a 1-to-1 relationship? That would fit the idea of an 'atomic' action more.
There was a problem hiding this comment.
I would agree that "atomic" implies it's one-to-one, but maybe this doesn't make sense for the researchers. If a messenger delivers three letters at once, you could consider that an "atomic action" as it can't be broken up into a sequence of actions.
I'd keep it like this for now, and check in in our next meeting.
|
|
||
| For instance, a political campaign (epistolary event) may consist of the writing, transporting and reading of individual letters (letter actions). | ||
| """ | ||
|
|
There was a problem hiding this comment.
I considered making EpistolaryEvents nestable, so one epistolary event (e.g. 'the Election of Pope Clement III') can have multiple Epistolary Events (e.g. 'Council of Troyes' and 'Murder of Baldwin of Nantes') etc., but we should probably ask the team first before we needlessly add more layers of complexity.
There was a problem hiding this comment.
I had the same idea. Indeed, let's do it like this for now, and check how the team wants to connect events. I can also imagine horizontal connections rather than hierarchical ones.
|
|
||
| For instance, a political campaign (epistolary event) may consist of the writing, transporting and reading of individual letters (letter actions). | ||
| """ | ||
|
|
There was a problem hiding this comment.
I had the same idea. Indeed, let's do it like this for now, and check how the team wants to connect events. I can also imagine horizontal connections rather than hierarchical ones.
|
|
||
| These can be grouped into epistolary events. | ||
| """ | ||
|
|
||
| letters = models.ManyToManyField( |
There was a problem hiding this comment.
I would agree that "atomic" implies it's one-to-one, but maybe this doesn't make sense for the researchers. If a messenger delivers three letters at once, you could consider that an "atomic action" as it can't be broken up into a sequence of actions.
I'd keep it like this for now, and check in in our next meeting.
This is a starting point for a discussion on how to resolve #8
In this PR: